search

cmu-db / bustub

The BusTub Relational Database Management System (Educational)
https://15445.courses.cs.cmu.edu/
MIT License
3.92k stars 1.76k forks source link

change return type uint32_t -> page_id_t for func GetDirectoryPageId #683

Closed dashjay closed 8 months ago

dashjay commented 8 months ago

An error type return by GetDirectoryPageId confused me for a long time, maybe there are also some who is not so familiar with CPP encountered this too. It return INVALID_PAGE_ID(-1) as uint32_t and get a super max one. Hope this can be fixed soon.

625

dashjay commented 8 months ago

@skyzh Hello MR. Chi PTLA~

Oh my good I finally found it.

skyzh commented 8 months ago

dup w/ https://github.com/cmu-db/bustub/pull/649, ping current course staff for further actions, thanks :) @yliang412