Thanks for your excellent tutotial for vector database beginners. When I follow your tutorial and test my implementions using the commands here, memory leak was reported by AddressSanitizer.
After debugging, I found the destructor of class Value was not implemented well for VECTOR type. So this PR fixed the bug by modifying destructor along with the copy constructor (The copy assignment operator do not need to change since it is pass by value).
After fixing the bug, the test can passed correctly without memory leak.
backport from https://github.com/skyzh/bustub-vectordb/pull/1 @UnpureRationalist
Hi there,
Thanks for your excellent tutotial for vector database beginners. When I follow your tutorial and test my implementions using the commands here, memory leak was reported by AddressSanitizer.
After debugging, I found the destructor of class
Valuewas not implemented well forVECTORtype. So this PR fixed the bug by modifying destructor along with the copy constructor (The copy assignment operator do not need to change since it is pass by value).After fixing the bug, the test can passed correctly without memory leak.