bug: Method `Tuple::KeyFromTuple` should be made `const`

cmu-db / bustub

The BusTub Relational Database Management System (Educational)

https://15445.courses.cs.cmu.edu

MIT License

4.04k stars 1.78k forks source link

bug: Method `Tuple::KeyFromTuple` should be made `const` #699

Closed Yaossg closed 2 months ago

Yaossg commented 8 months ago

I accidentally discovered that I cannot invoke Tuple::KeyFromTuple on a const reference of a Tuple because this method is not made const. However this method seems never modify any data member of Tuple.

Besides, clang-tidy agrees with me

Clang-Tidy: Method 'KeyFromTuple' can be made const