search

cmu-db / noisepage

Self-Driving Database Management System from Carnegie Mellon University
https://noise.page
MIT License
1.75k stars 503 forks source link

Unify pilot namespace #1608

Closed linmagit closed 3 years ago

linmagit commented 3 years ago

We have mixed namespace usage for code under the self_driving/planning folder. This PR makes them all under the noisepage::selfdriving::pilot namespace. I don't really think this needs review.

noisepage-checks[bot] commented 3 years ago

Minor Decrease in Performance

Be warned: this PR may have decreased the throughput of the system slightly.

tps (%change) benchmark_type wal_device details
-1.46% tpcc RAM disk
Detailsmaster tps=22692.16, commit tps=22359.93, query_mode=extended, benchmark_type=tpcc, scale_factor=32.0000, terminals=32, client_time=60, weights={'Payment': 43, 'Delivery': 4, 'NewOrder': 45, 'StockLevel': 4, 'OrderStatus': 4}, wal_device=RAM disk, max_connection_threads=32
-1.13% tpcc None
Detailsmaster tps=28982.5, commit tps=28655.06, query_mode=extended, benchmark_type=tpcc, scale_factor=32.0000, terminals=32, client_time=60, weights={'Payment': 43, 'Delivery': 4, 'NewOrder': 45, 'StockLevel': 4, 'OrderStatus': 4}, wal_device=None, max_connection_threads=32
0.71% tpcc HDD
Detailsmaster tps=21657.27, commit tps=21811.29, query_mode=extended, benchmark_type=tpcc, scale_factor=32.0000, terminals=32, client_time=60, weights={'Payment': 43, 'Delivery': 4, 'NewOrder': 45, 'StockLevel': 4, 'OrderStatus': 4}, wal_device=HDD, max_connection_threads=32
5.32% tatp RAM disk
Detailsmaster tps=6456.49, commit tps=6800.2, query_mode=extended, benchmark_type=tatp, scale_factor=1.0000, terminals=16, client_time=60, weights={'GetAccessData': 35, 'UpdateLocation': 14, 'GetNewDestination': 10, 'GetSubscriberData': 35, 'DeleteCallForwarding': 2, 'InsertCallForwarding': 2, 'UpdateSubscriberData': 2}, wal_device=RAM disk, max_connection_threads=32
-1.23% tatp None
Detailsmaster tps=7465.94, commit tps=7373.78, query_mode=extended, benchmark_type=tatp, scale_factor=1.0000, terminals=16, client_time=60, weights={'GetAccessData': 35, 'UpdateLocation': 14, 'GetNewDestination': 10, 'GetSubscriberData': 35, 'DeleteCallForwarding': 2, 'InsertCallForwarding': 2, 'UpdateSubscriberData': 2}, wal_device=None, max_connection_threads=32
4.04% tatp HDD
Detailsmaster tps=6468.3, commit tps=6729.92, query_mode=extended, benchmark_type=tatp, scale_factor=1.0000, terminals=16, client_time=60, weights={'GetAccessData': 35, 'UpdateLocation': 14, 'GetNewDestination': 10, 'GetSubscriberData': 35, 'DeleteCallForwarding': 2, 'InsertCallForwarding': 2, 'UpdateSubscriberData': 2}, wal_device=HDD, max_connection_threads=32
codecov[bot] commented 3 years ago

Codecov Report

Merging #1608 (1fdbd95) into master (b6f1d56) will decrease coverage by 0.09%. The diff coverage is 18.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1608      +/-   ##
==========================================
- Coverage   80.83%   80.74%   -0.10%     
==========================================
  Files         751      751              
  Lines       52698    52791      +93     
==========================================
+ Hits        42600    42626      +26     
- Misses      10098    10165      +67
Impacted Files Coverage Δ
src/include/catalog/catalog.h 80.00% <ø> (ø)
src/include/execution/compiler/executable_query.h 80.00% <ø> (ø)
src/include/execution/exec/execution_settings.h 83.33% <ø> (ø)
src/include/metrics/pipeline_metric.h 97.56% <ø> (ø)
...clude/self_driving/forecasting/workload_forecast.h 0.00% <ø> (ø)
...lf_driving/planning/mcts/monte_carlo_tree_search.h 0.00% <ø> (ø)
src/include/self_driving/planning/mcts/tree_node.h 0.00% <ø> (ø)
src/include/self_driving/planning/pilot.h 0.00% <ø> (ø)
src/include/self_driving/planning/pilot_thread.h 0.00% <ø> (ø)
src/include/settings/settings_manager.h 100.00% <ø> (ø)
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a283c6a...1fdbd95. Read the comment docs.