search

cmu-db / noisepage

Self-Driving Database Management System from Carnegie Mellon University
https://noise.page
MIT License
1.75k stars 503 forks source link

Refactor support for SHOW commands in DESCRIBE. #1631

Closed lmwnshn closed 3 years ago

lmwnshn commented 3 years ago

Heading

Refactor support for SHOW commands in DESCRIBE.

Description

Previously, DESCRIBE was writing NO DATA for SHOW. This fix makes the HikariCP connection pool in the new version of OLTPBench happy.

Remaining tasks

noisepage-checks[bot] commented 3 years ago

Major Decrease in Performance

STOP: this PR has a major negative performance impact

tps (%change) benchmark_type wal_device details
-6.16% tpcc RAM disk
Detailsmaster tps=22847.0, commit tps=21440.41, query_mode=extended, benchmark_type=tpcc, scale_factor=32.0000, terminals=32, client_time=60, weights={'Payment': 43, 'Delivery': 4, 'NewOrder': 45, 'StockLevel': 4, 'OrderStatus': 4}, wal_device=RAM disk, max_connection_threads=32
-2.19% tpcc None
Detailsmaster tps=29796.25, commit tps=29142.8, query_mode=extended, benchmark_type=tpcc, scale_factor=32.0000, terminals=32, client_time=60, weights={'Payment': 43, 'Delivery': 4, 'NewOrder': 45, 'StockLevel': 4, 'OrderStatus': 4}, wal_device=None, max_connection_threads=32
-1.94% tpcc HDD
Detailsmaster tps=21697.7, commit tps=21276.38, query_mode=extended, benchmark_type=tpcc, scale_factor=32.0000, terminals=32, client_time=60, weights={'Payment': 43, 'Delivery': 4, 'NewOrder': 45, 'StockLevel': 4, 'OrderStatus': 4}, wal_device=HDD, max_connection_threads=32
2.64% tatp RAM disk
Detailsmaster tps=6574.02, commit tps=6747.38, query_mode=extended, benchmark_type=tatp, scale_factor=1.0000, terminals=16, client_time=60, weights={'GetAccessData': 35, 'UpdateLocation': 14, 'GetNewDestination': 10, 'GetSubscriberData': 35, 'DeleteCallForwarding': 2, 'InsertCallForwarding': 2, 'UpdateSubscriberData': 2}, wal_device=RAM disk, max_connection_threads=32
-7.81% tatp None
Detailsmaster tps=7537.73, commit tps=6949.0, query_mode=extended, benchmark_type=tatp, scale_factor=1.0000, terminals=16, client_time=60, weights={'GetAccessData': 35, 'UpdateLocation': 14, 'GetNewDestination': 10, 'GetSubscriberData': 35, 'DeleteCallForwarding': 2, 'InsertCallForwarding': 2, 'UpdateSubscriberData': 2}, wal_device=None, max_connection_threads=32
5.52% tatp HDD
Detailsmaster tps=6546.74, commit tps=6907.92, query_mode=extended, benchmark_type=tatp, scale_factor=1.0000, terminals=16, client_time=60, weights={'GetAccessData': 35, 'UpdateLocation': 14, 'GetNewDestination': 10, 'GetSubscriberData': 35, 'DeleteCallForwarding': 2, 'InsertCallForwarding': 2, 'UpdateSubscriberData': 2}, wal_device=HDD, max_connection_threads=32
codecov[bot] commented 3 years ago

Codecov Report

Merging #1631 (e06c2ff) into master (845aedf) will decrease coverage by 0.00%. The diff coverage is 9.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1631      +/-   ##
==========================================
- Coverage   80.74%   80.73%   -0.01%     
==========================================
  Files         773      773              
  Lines       55420    55436      +16     
==========================================
+ Hits        44748    44756       +8     
- Misses      10672    10680       +8
Impacted Files Coverage Δ
src/include/traffic_cop/traffic_cop.h 71.42% <ø> (ø)
src/network/postgres/postgres_packet_util.cpp 37.07% <0.00%> (ø)
src/traffic_cop/traffic_cop.cpp 69.13% <0.00%> (+0.22%) :arrow_up:
src/network/postgres/postgres_network_commands.cpp 72.12% <10.52%> (-3.28%) :arrow_down:
src/execution/sema/sema_decl.cpp 79.24% <0.00%> (-1.89%) :arrow_down:
src/execution/sema/sema_expr.cpp 76.13% <0.00%> (-0.57%) :arrow_down:
src/parser/postgresparser.cpp 84.97% <0.00%> (+0.14%) :arrow_up:
src/execution/sql/vector.cpp 86.09% <0.00%> (+0.33%) :arrow_up:
src/network/connection_handle.cpp 64.34% <0.00%> (+0.77%) :arrow_up:
src/network/network_io_wrapper.cpp 85.48% <0.00%> (+3.22%) :arrow_up:
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 845aedf...e06c2ff. Read the comment docs.