Refactor CPUInfo::Instance singleton away.

apavlo commented 5 years ago

Greetings from the EWR airport. We need to start collecting information about the underlying hardware for our mini-trainers. To start with, we need to know the following things:

Number of CPU cores
CPU cache sizes.
CPU vendor info
Memory capacity
Disk bandwidth / fsync latency

All of these items except for the disk information can be collected from reading hardware tags.

The disk information is going to require microbenchmarks. So for now we can start with collecting CPU information.

After briefly searching, I did find this library that does what we want but (and way more than we need). I also don't know how the CC license plays with the MIT license:

https://github.com/ThePhD/infoware

Update

Our # 1 stunna @pmenon already has a class that already does what we want:

https://github.com/cmu-db/terrier/blob/4f0b62e873693ba5776d56a8604c70cb59dd7c1f/src/include/execution/util/cpu_info.h

We should clean up the API and remove his singleton nonsense.

lmwnshn commented 4 years ago

When would this be run? #1224 brings in a basic set of information:

-- Compiler: /usr/bin/c++ GNU 9.3.0
-- System: Linux 5.4.0-51-generic x86_64
--   System NUMBER_OF_LOGICAL_CORES;NUMBER_OF_PHYSICAL_CORES: 12;6
--   System HOSTNAME;FQDN: kapi;kapi
--   System AVAILABLE_VIRTUAL_MEMORY;TOTAL_VIRTUAL_MEMORY: 1331;2047
--   System AVAILABLE_PHYSICAL_MEMORY;TOTAL_PHYSICAL_MEMORY: 9973;15725
--   System IS_64BIT;HAS_IA64: 1;0
--   System HAS_FPU;HAS_MMX;HAS_MMX_PLUS: 1;1;0
--   System HAS_SSE;HAS_SSE2;HAS_SSE_FP;HAS_SSE_MMX: 1;1;0;0
--   System HAS_AMD_3DNOW;HAS_AMD_3DNOW_PLUS: 0;0
--   System HAS_SERIAL_NUMBER;PROCESSOR_SERIAL_NUMBER: 0;
--   System PROCESSOR_NAME;PROCESSOR_DESCRIPTION: Unknown P6 family;6 core Intel(R) Xeon(R) W-1250 CPU @ 3.30GHz
--   System OS_NAME;OS_RELEASE;OS_VERSION;OS_PLATFORM: Linux;5.4.0-51-generic;#56-Ubuntu SMP Mon Oct 5 14:28:49 UTC 2020;x86_64

But it sounds like you want a test target that computes stuff (since it'll have to gather disk information).

lmwnshn commented 3 years ago

CPUInfo made it into the repo. However, need to refactor the Instance away.

cmu-db / noisepage

Refactor CPUInfo::Instance singleton away. #460

Update