search

cmu-db / ottertune

The automatic DBMS configuration tool
Other
1.21k stars 310 forks source link

isolate workloads of different projects; extract workload merging process from recommandation #307

Closed yangdsh closed 4 years ago

yangdsh commented 4 years ago

The git lint will fail due to the added django migration file.

dvanaken commented 4 years ago

There are 8 errors in the unit tests too. Have you seen this?

yangdsh commented 4 years ago

There are 8 errors in the unit tests too. Have you seen this?

Basically the fixture file for the website test lack the project field I just added. I am fixing this by generating a new fixture file.

dvanaken commented 4 years ago

You can add the new migration file to this config so the linter will skip it: https://github.com/cmu-db/ottertune/blob/master/script/formatting/config/pylintrc#L16

yangdsh commented 4 years ago

@dvanaken It is all set now. The only failure is due to the new migration file.

yangdsh commented 4 years ago

You can add the new migration file to this config so the linter will skip it: https://github.com/cmu-db/ottertune/blob/master/script/formatting/config/pylintrc#L16

OK

yangdsh commented 4 years ago

@dvanaken Thank you! Now it is good to go! Yesterday I have run tests to verify that it did isolate the workloads from different projects, and my changes to the async_test did not break anything. Next, I plan to merge the DDPG recommendation pipeline with the GPR/DNN pipeline to make the code cleaner. However, if you have urgent things for me, I can do them first.

dvanaken commented 4 years ago

Awesome thanks @yangdsh