search

cmu-db / peloton

The Self-Driving Database Management System
http://pelotondb.io
Apache License 2.0
2.04k stars 623 forks source link

fix 'not a supported wheel on this platform' error when running package.sh on Ubuntu 17.10 #1251

Closed Nov11 closed 6 years ago

Nov11 commented 6 years ago

what happened? I encountered this error when I executed package.sh on my machine. 'tensorflow-1.5.0-cp35-cp35m-linux_x86_64.whl is not a supported wheel on this platform.' my system info : OS version:Ubuntu 17.10 python3 version: Python 3.6.3 what's changed ? version number after 'cp' is changed corresponding to version of python3. 35 to 36. does this fix the problem? I tried on my machine. the error is gone. the script works as expected.

saatviks commented 6 years ago

Thanks for the PR @Nov11.

I actually think that with the SSL test being fixed in a previous PR, the problem described in #1214 should be resolved. Instead of using a hardcoded tensorflow binary URL everywhere for python-tensorflow, it would be better to do something like pip install tensorflow==$TF_VERSION.

I think it would be more helpful to set this up instead.

Edit: Additionally do correct me if I'm wrong but python 3.5.3 is the default on Ubuntu 17.04(link). Its only on Ubuntu 17.10 onward that python 3.6 becomes the default. So this fix might work for Ubuntu 17.10 but break Ubuntu 17.04.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.2%) to 76.979% when pulling e6c1a2cd1e84b13988ecc7ab219cc78fb3052378 on Nov11:fix-tensorflow-install-ubuntu1710 into b8bf0bbfa79f9591657568aac0be01c5d82cb3f4 on cmu-db:master.

Nov11 commented 6 years ago

you're right. I added a if clause so that the script can get the correct binary url on 17.04.

I tried to specify version number after package name. It seems that this is not working for the moment. Here's error message: +sudo -E pip3 install tensorflow==1.4.0 Downloading/unpacking tensorflow==1.4.0 Could not find any downloads that satisfy the requirement tensorflow==1.4.0 guess i need to revert this modification

saatviks commented 6 years ago

The default pip needs to be upgraded for the tensorflow install to work. You have to do pip3 install --upgrade pip followed by pip install --upgrade tensorflow==1.4.0. Additionally Ubuntu 16/17 should use tensorflow version 1.5.0.

Edit: My point is there should be no need for the hardcoded urls.

Nov11 commented 6 years ago

those urls have been removed. the script should work as expected for now

saatviks commented 6 years ago

Looks good - You'll need to update your branch to resolve the jenkins failiure.

saatviks commented 6 years ago

This LGTM.

saatviks commented 6 years ago

@malin1993ml @pervazea I think we should merge this in if its passing Jenkins too.

pervazea commented 6 years ago

Sure. Will try to do this next.

Is this holding you up?

From: Saatvik Shah notifications@github.com Sent: Friday, April 6, 2018 5:01 PM To: cmu-db/peloton Cc: Pervaze Akhtar; Mention Subject: Re: [cmu-db/peloton] fix 'not a supported wheel on this platform' error when running package.sh on Ubuntu 17.10 (#1251)

@malin1993mlhttps://github.com/malin1993ml @pervazeahttps://github.com/pervazea I think we should merge this in if its passing Jenkins too.

- You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/cmu-db/peloton/pull/1251#issuecomment-379377437, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AhDfwDs6MqBlb_6rDKlcQjASCOLivYs2ks5tl9e3gaJpZM4TC88G.

saatviks commented 6 years ago

No - was just asking since it would clean up the packages.sh.