Closed mengranwo closed 6 years ago
Hey @poojanilangekar!
Thank you for your reviews and I've made changes according to your suggestion. The following is a summary to what I've modified and answers to some of your question.
@tcm-marcel, The same issue again. Travis build is not triggered. Do you think the bug is because of some error in our configuration or a bug on their end?
@poojanilangekar Thanks for your comments. We are working on adding more tests, if possible, once we have time.
@camellyx Can this PR be merged in for now? You can add more tests in the subsequent PR. If this gets merged in and I merge in the layout PR #1327, then we can start work on schema change. Or do you want to wait? Let me know what works for you.
@poojanilangekar I think we are ready to go.
Thanks @mengranwo! @pervazea @apavlo Can you please merge this in?
@mengranwo I think there are typos in src/include/catalog/catalog_defaults.h and other places. DEFUALT_SCHEMA_OID
and DEFUALT_SCHEMA_NAME
which should be DEFAULT_SCHEMA_OID
and DEFAULT_SCHEMA_NAME
1. catalog refactoring
2. Namespace(Schema) support
3. To-Do
Fix test cases (consult with PR #1286)