search

cmu-db / peloton

The Self-Driving Database Management System
http://pelotondb.io
Apache License 2.0
2.04k stars 622 forks source link

Fix for python-six upgrade on Ubuntu 14.04 #1303

Closed pervazea closed 6 years ago

linmagit commented 6 years ago

@pervazea I think #1248 also fixes this issue by doing this: https://github.com/cmu-db/peloton/pull/1248/files#diff-46454d00238f98e83096b2d44703df7eR76

That PR is very close to be ready except a minor namespace closure thing. I'm not sure which way is better though.

pervazea commented 6 years ago

Now I'm a little confused as I look at this closer, so I have questions:

  1. You are using pip3 (=> python3).

  2. My fix is incorrect. It should reference python3-six not python-six

  3. With "your" fix though, will it uninstall the old version of python3-six? If so, I'm fine with it. If both old and new versions will be installed, then I'd suggest, uninstalling the old version to avoid problems in selecting which version to import.

From: Lin Ma notifications@github.com Sent: Monday, April 16, 2018 1:49 PM To: cmu-db/peloton Cc: Pervaze Akhtar; Mention Subject: Re: [cmu-db/peloton] Fix for python-six upgrade on Ubuntu 14.04 (#1303)

@pervazeahttps://github.com/pervazea I think #1248https://github.com/cmu-db/peloton/pull/1248 also fixes this issue by doing this: https://github.com/cmu-db/peloton/pull/1248/files#diff-46454d00238f98e83096b2d44703df7eR76

That PR is very close to be ready except a minor namespace closure thing. I'm not sure which way is better though.

- You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/cmu-db/peloton/pull/1303#issuecomment-381691007, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AhDfwISxG66aK9hOu5ibj3Du6nNWly6xks5tpNmSgaJpZM4TW99L.

linmagit commented 6 years ago

@pervazea Yes, we're using Python3.

@saatviks Can you answer the third one, and adjust your PR accordingly if it does not uninstall the old version?

pervazea commented 6 years ago

Thanks.

You should be able to easily tell by looking in

/usr/lib/python3/dist-packages

ls -l six*

should show you only the updated version of six, if it removed the old one.

From: Lin Ma notifications@github.com Sent: Monday, April 16, 2018 2:28 PM To: cmu-db/peloton Cc: Pervaze Akhtar; Mention Subject: Re: [cmu-db/peloton] Fix for python-six upgrade on Ubuntu 14.04 (#1303)

@pervazeahttps://github.com/pervazea Yes, we're using Python3.

@saatvikshttps://github.com/saatviks Can you answer the third one, and adjust your PR accordingly if it does not uninstall the old version?

- You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/cmu-db/peloton/pull/1303#issuecomment-381703431, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AhDfwC0l6cqe2YPVTBzmiJmX_BIiLdtlks5tpOLDgaJpZM4TW99L.

saatviks commented 6 years ago

@pervazea the new PR is installing tensorflow as pip3 install tensorflow==${TF_VERSION} --upgrade --ignore-installed six. This way even in the future if python3-six is already installed it will not install or update it. Does this look alright?

pervazea commented 6 years ago

I'm fine with trying this approach.

Just to clarify though, pip3 man page says:

   -I, --ignore-installed
          Ignore the installed packages (reinstalling instead).

I interpret that to mean, ignore the package version, don't try to uninstall it. It is being re-installed with a different version.

The risk I see, is that if a package is not uninstalled, re-installing may install the new version but leave files or other artifacts of the old version. (apt does know how to uninstall the six package. pip does not).

From: Saatvik Shah notifications@github.com Sent: Monday, April 16, 2018 3:16 PM To: cmu-db/peloton Cc: Pervaze Akhtar; Mention Subject: Re: [cmu-db/peloton] Fix for python-six upgrade on Ubuntu 14.04 (#1303)

@pervazeahttps://github.com/pervazea the new PR is installing tensorflow as pip3 install tensorflow==${TF_VERSION} --upgrade --ignore-installed six. This way even in the future if python3-six is already installed it will not install or update it. Does this look alright?

- You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/cmu-db/peloton/pull/1303#issuecomment-381717869, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AhDfwFQbEUiwKQGhYTm9yUyNOLmk68MZks5tpO4igaJpZM4TW99L.

saatviks commented 6 years ago

Yes your right I had misunderstood what it meant. We can then replace my fix with this PR instead. I dont think you need to check the version during remove - You can directly run: sudo apt-get remove --purge python3-six?

pervazea commented 6 years ago

Yes, your fix below sounds good.

From: Saatvik Shah notifications@github.com Sent: Tuesday, April 17, 2018 1:29 PM To: cmu-db/peloton Cc: Pervaze Akhtar; Mention Subject: Re: [cmu-db/peloton] Fix for python-six upgrade on Ubuntu 14.04 (#1303)

Yes your right I had misunderstood what it meant. We can then replace my fix with this PR instead. I dont think you need to check the version during remove - You can directly run: sudo apt-get remove --purge python3-six?

- You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/cmu-db/peloton/pull/1303#issuecomment-382076528, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AhDfwNWj-r7ZmL3QLlYGZWjaLrB6txdpks5tpiaTgaJpZM4TW99L.