Closed pervazea closed 6 years ago
Fix Travis and Jenkins, yes? Also, modify compile options to explicitly set C++11 standard: -std=c++11
.
See #1309 for Jenkins, and yes to -std=c++11 (thanks for the correction / reminder)
I'll coordinate w/ Marcel, if we can combine the changes into 1 PR once we have the changes.
Should we include other gcc versions in the build? And if yes, in travis or in Jenkins? I would prefer to keep the travis build simple, as it is easier for us the scale the Jenkins builds.
Adapting the sources to build with clang under Linux is also still open: #1227 (I didn't find time for this yet)
Can someone explain to me how Jenkins picks the compiler version? I can't find any version information in the Jenkinsfile [1], except for the stage titles, but the stages do use the desired compiler version.
[1] https://github.com/cmu-db/peloton/blob/master/Jenkinsfile
No idea : -)
From what I can see, the docker container for Ubuntu 14.04 only has a single compiler version installed, so no picking is required. What I'm looking to do is to install gcc 5 and use update-alternatives to make gcc 5 the preferred version. This is temporary. Once we update the docker images with dependencies we can have all this pre-configured.
LMK if you think this is wrong or have a better approach.
From: Marcel Kost notifications@github.com Sent: Wednesday, April 18, 2018 6:17 PM To: cmu-db/peloton Cc: Pervaze Akhtar; Author Subject: Re: [cmu-db/peloton] Fix Travis to use gcc5 (#1308)
Can someone explain to me how Jenkins picks the compiler version? I can't find any version information in the Jenkinsfile [1], except for the stage titles, but the stages do use the desired compiler version.
[1] https://github.com/cmu-db/peloton/blob/master/Jenkinsfile
- You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/cmu-db/peloton/issues/1308#issuecomment-382546769, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AhDfwKX7wIHKCevg5TR4SY7Jh1A1eZaiks5tp7t3gaJpZM4TajXW.
On 2018-04-18 18:24, pervazea wrote:
From what I can see, the docker container for Ubuntu 14.04 only has a single compiler version installed, so no picking is required.
That is correct. There are more versions available from the package repository but the pre-installed version is whatever the unadorned "g++" package refers to: gcc-4.8 in the trusty case, and gcc-5.4 in the xenial case.
What I'm looking to do is to install gcc 5 and use update-alternatives to make gcc 5 the preferred version. This is temporary. Once we update the docker images with dependencies we can have all this pre-configured.
Regarding this and your separate note about updating the docker images with all the new dependencies, could you please specify what version(s) of the compiler you'd like to have pre-installed?
Superceded by #1309
Discontinue use of gcc4.8