search

cmu-db / peloton

The Self-Driving Database Management System
http://pelotondb.io
Apache License 2.0
2.03k stars 623 forks source link

Jenkins update to gcc5 #1311

Closed pervazea closed 6 years ago

pervazea commented 6 years ago

Also update cmake to use c++11

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.01%) to 77.267% when pulling 6352488351065cf3cd89ea4b7b108badd86880b9 on pervazea:jenkins into fd4a31cd8f9817eb916da0c2b84b89a25e4b1235 on cmu-db:master.

pmenon commented 6 years ago

@pervazea Why do we need -Wno-c++14-compat now?

Update: Spoke with @pervazea offline. Turns out we have some custom allocation code that doesn't work in C++14, hence the C++14 compatibility warning suppression. Note: We'll have to revisit this if we choose to move to C++14.

LGTM.

pervazea commented 6 years ago

Same intermittent memory leak failure on the query_logger_test. Otherwise passed on Jenkins. I'm going to re-run the Jenkins build, just to see how reproducible the query_logger_test issue is.

pmenon commented 6 years ago

Actually, @pervazea do we also want to build and run the test suite for macOS on Travis?

pervazea commented 6 years ago

Test suite for macOS on Travis, sure. I'll do it as a follow up though. Get this in and unblock progress.