cmu-db / peloton

The Self-Driving Database Management System
http://pelotondb.io
Apache License 2.0
2.04k stars 622 forks source link

Packages Script Does Not Check for Protobuf Compilation Errors #1312

Closed apavlo closed 6 years ago

apavlo commented 6 years ago

I ran packages.sh on my Ubuntu 17.10 machine. It is unable to compile the protobuf dependency but the script just keeps running. There is no indication at the end that the installation failed.

I think you need to check for a non-zero exist code in the install_protobuf3.4.0 function.

https://github.com/cmu-db/peloton/blob/master/script/installation/packages.sh#L61

Log is here: ubuntu-17_10.log

saatviks commented 6 years ago

Resolved with #1406