pervazea commented 6 years ago

Regarding this and your separate note about updating the docker images with all the new dependencies, could you please specify what version(s) of the compiler you'd like to have pre-installed?

For gcc, lets go with 5.4.0 which is the version (default I believe) on Ubuntu 16.04.

We have updated Jenkins and Travis to use the above gcc 5 version, removed gcc 4 builds from Travis.

Next is to update the docker images, to reduce build time.

crd477 commented 6 years ago

OK, this is completed for the Ubuntu Trusty and Xenial images since they're currently enabled in Jenkins. I can update other images if you'd like but it's probably better to wait until there is interest in supporting those.

22 still built those packages as I stupidly created the PR moments before the updated images had finished importing on all of the workers.

pervazea commented 6 years ago

A couple of people are reporting failures on Jenkins Trusty images. Haven't diagnosed yet, but I suspect there is something not correct in the new images.

From: Chad Dougherty notifications@github.com Sent: Tuesday, April 24, 2018 8:30 AM To: cmu-db/peloton Cc: Pervaze Akhtar; Author Subject: Re: [cmu-db/peloton] Update docker images with dependencies (#1317)

OK, this is completed for the Ubuntu Trusty and Xenial images since they're currently enabled in Jenkins. I can update other images if you'd like but it's probably better to wait until there is interest in supporting those.

1328https://github.com/cmu-db/peloton/pull/1328 is also related so that tensorflow and protobuf don't get built and installed unconditionally. They're already installed in the docker builder images though.

- You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/cmu-db/peloton/issues/1317#issuecomment-383912641, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AhDfwB1Q-vJ84ww2osQRPWI-uZN_Q90pks5trxrmgaJpZM4TdgJB.

pervazea commented 6 years ago

Docker images seem fine, but breaks after we run packages.sh

From: Pervaze Akhtar Sent: Tuesday, April 24, 2018 10:47 AM To: cmu-db/peloton Subject: Re: [cmu-db/peloton] Update docker images with dependencies (#1317)

A couple of people are reporting failures on Jenkins Trusty images. Haven't diagnosed yet, but I suspect there is something not correct in the new images.

From: Chad Dougherty notifications@github.com Sent: Tuesday, April 24, 2018 8:30 AM To: cmu-db/peloton Cc: Pervaze Akhtar; Author Subject: Re: [cmu-db/peloton] Update docker images with dependencies (#1317)

OK, this is completed for the Ubuntu Trusty and Xenial images since they're currently enabled in Jenkins. I can update other images if you'd like but it's probably better to wait until there is interest in supporting those.

1328https://github.com/cmu-db/peloton/pull/1328 is also related so that tensorflow and protobuf don't get built and installed unconditionally. They're already installed in the docker builder images though.

- You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/cmu-db/peloton/issues/1317#issuecomment-383912641, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AhDfwB1Q-vJ84ww2osQRPWI-uZN_Q90pks5trxrmgaJpZM4TdgJB.

crd477 commented 6 years ago

Could you please elaborate on what is breaking? I tested multiple invocations of packages.sh with 2ff8c44b8c89cd1242860290e928eb5cf2bdb3b0 applied and did not have any problems.

cmu-db / peloton

Update docker images with dependencies #1317

1328https://github.com/cmu-db/peloton/pull/1328 is also related so that tensorflow and protobuf don't get built and installed unconditionally. They're already installed in the docker builder images though.

1328https://github.com/cmu-db/peloton/pull/1328 is also related so that tensorflow and protobuf don't get built and installed unconditionally. They're already installed in the docker builder images though.