cmu-db / peloton

The Self-Driving Database Management System
http://pelotondb.io
Apache License 2.0
2.04k stars 622 forks source link

Update LLVM to 5.0 or 6.0 #1318

Open pmenon opened 6 years ago

pmenon commented 6 years ago

LLVM versions older than 4.0 seem to be generating bogus code on our newer KabyLake servers, making a few of the tests fail. LLVM 4.0 and above fixes these issues. But, if we're considering an upgrade, I'd like to explore LLVM 5.0 and 6.0 as upgrade targets, too.

pervazea commented 6 years ago

Matt tried out Ubuntu 18.04 over the weekend. Packages.sh does not work as LLVM 3.7 doesn't install.

So, likely that we'll want to upgrade LLVM in conjunction with moving to 18.04. If there are any other outdated (unsupported) components moving to 18.04, those too.

mbutrovich commented 6 years ago

Have a branch going that has been tested in the following configurations:

Ubuntu 16.04 (dev5): LLVM 3.7 (fails, but expected due to bad CPU support) LLVM 5.0 (passes make check, Debug, ASAN on) LLVM 6.0 (passes make check, Debug, ASAN on)

macOS: LLVM 3.7 (passes make check, Debug, ASAN on) LLVM 6.0 (passes make check, Debug, ASAN on)

I'm going to do a quick LLVM 3.7 check on an Ubuntu VM, and then open a PR for Travis and Jenkins testing.

crd477 commented 6 years ago

Cool!