search

cmu-db / peloton

The Self-Driving Database Management System
http://pelotondb.io
Apache License 2.0
2.03k stars 623 forks source link

Added more query cache test for binding tuple value expression #1333

Closed nwang57 closed 6 years ago

nwang57 commented 6 years ago

Talked with @chenboy regarding #1298 , he prefers manually call SetBoundOid() to bind the tuple value expression in order to make the expression equality check work.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.01%) to 77.403% when pulling abd9cec8689cce5572739d0d3599dfb78fa93661 on nwang57:query_cache into 881a8e6d34296d372593ac9714d6a71a5500f82c on cmu-db:master.

saatviks commented 6 years ago

@nwang57 I'm guessing this PR is ready for review?

nwang57 commented 6 years ago

Yeah, thanks @saatviks . I can't change the label tho.

saatviks commented 6 years ago

@chenboy waiting on your review to this PR?

nwang57 commented 6 years ago

@chenboy Hi, I have solved all the issues. Please have a look at it again, thanks.

saatviks commented 6 years ago

@chenboy could you take a look at this?

chenboy commented 6 years ago

I believe there're still unresolved comments. I think we may want to also check the content of the tuples returned.

Edit : I missed the newer commits. I think it's good to go.

apavlo commented 6 years ago

I will merge this when the build passes.