Remove wrong check in QueryCompiler::IsSupported

cmu-db / peloton

The Self-Driving Database Management System

http://pelotondb.io

Apache License 2.0

2.03k stars 623 forks source link

Remove wrong check in QueryCompiler::IsSupported #1378

Closed tcm-marcel closed 6 years ago

tcm-marcel commented 6 years ago

(as discussed in the team meeting today)

We do support ExpressionType::VALUE_PARAMETER in the codegen engine, even though IsSupported says otherwise. Only tested by running the test suite.

coveralls commented 6 years ago

Coverage decreased (-0.6%) to 77.881% when pulling 3bcd45e39d2737368b6252b7a5f72d3a5417cb23 on tcm-marcel:fix/issupported into 671e4bd7e7b3c515cfe86344992da12e326194c1 on cmu-db:master.

pmenon commented 6 years ago

Looks like the prepared_stmt_test is failing due to the serialization issue identified in #1377. Let's wait for a fix to that before merging this. Or include this PR into a PR that fixes the larger issue.

tli2 commented 6 years ago

@tcm-marcel Just FYI you can fix the failing test by explicitly issuing PREPARE and EXECUTE SQL queries. The bug is not necessarily due to a bug in the network layer, but rather lack of ability to do type inference, which is unlikely to be implemented soon.