cmu-db / peloton

The Self-Driving Database Management System
http://pelotondb.io
Apache License 2.0
2.03k stars 623 forks source link

Resolves Clang warnings and LLVM assertion failure on Mac #1379

Closed mbutrovich closed 6 years ago

mbutrovich commented 6 years ago

Resolves the following introduced after merging PR #1304:

/peloton/src/codegen/function_builder.cpp:137:5: error: ‘~FunctionBuilder’ has a non-throwing exception specification but can still throw [-Werror,-Wexceptions] /peloton/src/codegen/function_builder.cpp:135:18: note: destructor has a implicit non-throwing exception specification

/peloton/src/codegen/operator/table_scan_translator.cpp:219:37: error: lambda capture ‘table’ is not used [-Werror,-Wunused-lambda-capture]

/peloton/src/codegen/util/sorter.cpp:271:56: error: lambda capture ‘comp’ is not used [-Werror,-Wunused-lambda-capture]

/peloton/test/codegen/hash_table_test.cpp:100:17: error: variable ‘c1’ cannot be implicitly captured in a lambda with no capture-default specified /peloton/test/codegen/hash_table_test.cpp:142:17: error: variable ‘c1’ cannot be implicitly captured in a lambda with no capture-default specified /peloton/test/codegen/hash_table_test.cpp:189:17: error: variable ‘c1’ cannot be implicitly captured in a lambda with no capture-default specified /peloton/test/codegen/hash_table_test.cpp:222:43: error: lambda capture ‘to_insert’ is not required to be captured for this use [-Werror,-Wunused-lambda-capture]

Assertion failed: (isValidElementType(EltTy) && “Invalid type for pointer element!“), function get, file /private/tmp/llvm@3.7-20170923-4009-1tn3kci/llvm-3.7.1.src/lib/IR/Type.cpp, line 740.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.008%) to 77.412% when pulling f1ce2c3d858611d3570cc0747ee76e244b2e5a44 on mbutrovich:clang_fixes into 94012458140dced1cba836c1d173dde0a05be7e4 on cmu-db:master.