We should separate the visibility check from the addition to the read-write set in TransactionRuntime::PerformVectorizedRead(). (transaction_runtime.cpp line 28)
Visibility should be checked for all tuples, but PerformRead() should only be called for tuples that pass the scan predicate. Otherwise, all visible tuples will be added to the read-write set, which is too conservative. (Prashanth suggesting splitting the function into two. Check visibility. Interpose scan predicate check. Second portion that does PerformRead).
The last argument to TransactionManager::PerformRead() should not be false (transaction_runtime.cpp, line 62).
It should be a function argument fed from the scan plan (i.e., SeqScanPlan::IsForUpdate).
The first change should yield significant improvement for high-selectivity predicates since 54% of time is spend in PerformRead(). The second one is for correctness.
We should separate the visibility check from the addition to the read-write set in TransactionRuntime::PerformVectorizedRead(). (transaction_runtime.cpp line 28) Visibility should be checked for all tuples, but PerformRead() should only be called for tuples that pass the scan predicate. Otherwise, all visible tuples will be added to the read-write set, which is too conservative. (Prashanth suggesting splitting the function into two. Check visibility. Interpose scan predicate check. Second portion that does PerformRead).
The last argument to TransactionManager::PerformRead() should not be false (transaction_runtime.cpp, line 62). It should be a function argument fed from the scan plan (i.e., SeqScanPlan::IsForUpdate).
The first change should yield significant improvement for high-selectivity predicates since 54% of time is spend in PerformRead(). The second one is for correctness.