search

cmu-db / peloton

The Self-Driving Database Management System
http://pelotondb.io
Apache License 2.0
2.03k stars 624 forks source link

Support limit, offset, top-k serial and parallel versions in codegen #1435

Closed pmenon closed 6 years ago

pmenon commented 6 years ago

After #1385 was merged in, I resurrected LIMIT, OFFSET from my old branch, and implemented Top-K optimizations. These both work for serial and parallel execution, and are needed for TPC-C.

Not quite ready for merging in, but folks can take a look at it.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.05%) to 76.421% when pulling 0e2de1e3e0a21121a384ce37d5cb5275555cf02a on pmenon:limit into 2406b763b91d9cee2a5d9f4dee01c761b476cef6 on cmu-db:master.

pmenon commented 6 years ago

@tcm-marcel Want to take a last crack at this? Don't want this to get stale.

apavlo commented 6 years ago

@tcm-marcel I think this is stuck on the Jenkins mac build?

tcm-marcel commented 6 years ago

The Jenkins Mac build fails because no space is left on the hard drive:

/tmp/workspace/peloton_PR-1435-XOL5JG3LYATJV2HWKIVAIOIZQP2OCJC5FY5VVGBXQZ6BT33JVMUA@2: No space left on device

@apavlo I am not familiar with the Jenkins Mac machine. But on Travis the Mac build succeeds.

apavlo commented 6 years ago

@crd477 Can you check this?

crd477 commented 6 years ago

Fixed with the quick fix of restarting the VM from a clean snapshot. The more complete fix of how to do this cleanly and regularly was still on my TODO list before I left for vacation last week and I'll get back to it today. I also restarted the Jenkins builds for master and #1435. They should pass soon.

crd477 commented 6 years ago

The macOS Jenkins worker should be stable now. I grew the VM's disk and added a workspace cleanup cronjob as the other Jenkins workers have.