search

cmu-db / peloton

The Self-Driving Database Management System
http://pelotondb.io
Apache License 2.0
2.03k stars 624 forks source link

Fix for optimizer rule bug #1468

Closed GustavoAngulo closed 5 years ago

GustavoAngulo commented 5 years ago

Fixes false positive in rule checking (#1234). The error was being caused by incorrect use of bitmap.set function. I also added a plan printing helper function. Lastly, I improved our group expression equality function. While it's not a complete fix to #1354, it helps.

@apavlo For some reason PR #1245 never got checked in (it says merged but the changes aren't in the code), so I'm submitting this one. We never merged in my PR for the class (#1344), however, that also included the bug fixes we found during the semester. I'm gonna add those in separate PRs like this one.

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.007%) to 76.546% when pulling 486b4cca9bb48820569e380463622f11a65e8611 on GustavoAngulo:optimizer_bugs into 1de89798f271804f8be38a71219a20e761a1b4b6 on cmu-db:master.