search

cmu-db / peloton

The Self-Driving Database Management System
http://pelotondb.io
Apache License 2.0
2.04k stars 623 forks source link

LLVM 3.9 for macOS #1482

Closed mbutrovich closed 6 years ago

mbutrovich commented 6 years ago

Fix for #1478, hopefully.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.03%) to 76.488% when pulling 7ded4431fa06bf2d28809abc377914be3d567fd4 on mbutrovich:llvm_39 into 6898305bc5b2f73b7a027f154fa650e24e706fbe on cmu-db:master.

mbutrovich commented 6 years ago

I dunno why Jenkins isn't running. I'll look again in the morning, but I don't think my changes would have any effect on Jenkins triggering.

crd477 commented 6 years ago

Disregard my other stupid comment. I believe I've fixed this in the VM image. A permissions problem for the jenkins user when invoking brew prevented llvm from being installed

crd477 commented 6 years ago

For the record, it worked for me in the other project and I expect it will work here too. I'll submit a PR in the other one shortly. One other change I made was to reduce the number of executors on the macOS build VM from 4 to 1. This will prevent those failures where two build are trying to run brew simultaneously.