search

cmu-delphi / covidcast-indicators

Back end for producing indicators and loading them into the COVIDcast API.
https://cmu-delphi.github.io/delphi-epidata/api/covidcast.html
MIT License
12 stars 17 forks source link

replace the python covidcast client in validator #1972

Open melange396 opened 4 weeks ago

melange396 commented 4 weeks ago

Similar to #1931, the python covidcast client (which has some issues) is used in the delphi_utils.validator submodule and it can should come out of there:

melange396 commented 1 week ago

One interesting quirk of the covidcast client is that it pins "pandas<2", which nets version 1.5.3 (from ~1.5y ago)...

I find no reason/rationale for this in either the source or comments of https://github.com/cmu-delphi/covidcast/pull/618 where the change was made :(

This also means that anything that imports the delphi_utils package inherits the version restriction.

The current version of Pandas is 2.2.2 -- which might offer significant performance improvements, but it risks breaking any number of things. Pandas is not pinned anywhere in this repo (except for the now-toothless spec in delphi_utils to >=1.1.0), so completing this issue may require changes or pinning in individual indicator code. EDIT: version pinning issue https://github.com/cmu-delphi/covidcast-indicators/issues/1967 may be relevant for this.