cmu-delphi / covidcast-indicators

Back end for producing indicators and loading them into the COVIDcast API.
https://cmu-delphi.github.io/delphi-epidata/api/covidcast.html
MIT License
12 stars 17 forks source link

Regularize data fetching methods #366

Open sgsmob opened 4 years ago

sgsmob commented 4 years ago

There are many different ways the indicators fetch remote data (email, AWS S3, cURL, sftp, etc.) and each one does so in a different spot. It would be helpful to have some regularized interface for data fetching (say, an AbstractDataFetcher class from which EmailDataFetcher, etc. inherit) as part of all indicators to consistently and clearly handle data fetching and any associated failures.

chinandrew commented 4 years ago

Was curious and did an inventory of data fetching methods for reference.

krivard commented 3 years ago

@mariajahja do you have details on how claims_hosp fetches source data? Is it a separate process that pulls from a magic email address? It might be good to normalize that with how quidel does it.

mariajahja commented 3 years ago

@krivard It’s a separate python script (using paramiko) that pulls from a private Delphi ftp server. HSP deposits them there directly, and a bigchunk machine downloads it locally, runs the sensor update, then deletes the copy.

If it’s helpful, back when HSP used email @korlaxxalrok created a script to pull that data.