search

cmu-delphi / covidcast

R and Python packages supporting Delphi's COVIDcast effort.
https://delphi.cmu.edu/covidcast/
33 stars 28 forks source link

HRR and MSA data not showing up properly in choropleth plots for covidcast #381

Closed sarah-colq closed 3 years ago

sarah-colq commented 3 years ago

The data showing up in the R version looks different than the Python version. We presume the R version is wrong because it was behaving before using the shapefiles instead of usmap.

capnrefsmmat commented 3 years ago

Could you say what specifically seemed wrong? I just made an MSA plot where I set all MSAs to have 0 values except a couple, and their values appeared in the correct places.

chinandrew commented 3 years ago

We stumbled upon it while debugging the svg issue, slack post here

sarah-colq commented 3 years ago

@capnrefsmmat Can we close this?

capnrefsmmat commented 3 years ago

I think so, but worth double checking. My fix only affected HRR maps, and when I plotted MSA maps with the current version of the package on r-pkg-devel, they looked fine. If they also look fine to you, then I think we're fine to close this