cmu-delphi / covidcast

R and Python packages supporting Delphi's COVIDcast effort.
https://delphi.cmu.edu/covidcast/
33 stars 27 forks source link

Remove usage of PHP alias in the Python client #663

Closed rzats closed 11 months ago

rzats commented 1 year ago

Secondary PR to https://github.com/cmu-delphi/delphi-epidata/pull/1288 that should be merged & deployed alongside it - fixed the delphi-epidata version to the newest client.

capnrefsmmat commented 1 year ago

Since the Epidata cient API is changing, we'll need to update the version number required in setup.py along with these changes, so users are guaranteed to have the updated version of the client.

rzats commented 1 year ago

@capnrefsmmat good point! I bumped the version once and will change it again if the release ends up being e.g. 4.1.3.

melange396 commented 1 year ago

Did you get a chance to run tests for this with the updated client from https://github.com/cmu-delphi/delphi-epidata/pull/1288 ? I think you might need to update the .return_values for the @patched async_epidata(): https://github.com/cmu-delphi/covidcast/blob/474dc20ad2f123b5b89d21f8443ee107537fe84e/Python-packages/covidcast-py/tests/test_covidcast.py#L261-L263

melange396 commented 1 year ago

can we update the changelog, and then follow this set of instructions to update the version number for the package and rebuild docs and other artifacts? then we will be prepped to upload to PyPI when everything else is done.

melange396 commented 1 year ago

@dshemetov makes a good point in https://github.com/cmu-delphi/delphi-epidata/pull/1288#issuecomment-1749368736 ... we should probably put documentation and show warning messages for deprecating _async_fetch_epidata(), just in case anyone is using it.

melange396 commented 11 months ago

@rzats this is failing at the linter now, i guess you didnt go through that part of the tests?

melange396 commented 11 months ago

linting/pydocstyle is happy now, but now python tests are failing... @rzats can you take a look?

rzats commented 11 months ago

@melange396 latest round of tests is passing!