cmu-delphi / delphi-epidata

An open API for epidemiological data.
https://cmu-delphi.github.io/delphi-epidata/
MIT License
100 stars 62 forks source link

Add `min_issue` to metadata #1413

Open nmdefries opened 3 months ago

nmdefries commented 3 months ago

Closes https://github.com/cmu-delphi/delphi-epidata/issues/232

Summary:

Calculate and include min_issue in metadata.

Prerequisites:

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

melange396 commented 3 months ago

I know why that test is failing, and its related to a semi-bug that i thought i had documented already (but i apparently didn't). We can work around it with a small change to the test -- i will show you tomorrow or monday.

melange396 commented 2 months ago

The test failure stems from this issue i just created: https://github.com/cmu-delphi/delphi-epidata/issues/1427

You can fix this PR in the meantime by changing the way rows are created and inserted by the failing test... Right now, it creates the rows by a list comprehension and then inserts them all at once. I think that if you move the call to self._insert_rows() inside of one or both of those for loops, it should do the trick (🤞).

nmdefries commented 2 months ago

Changed that here. Based on the previous failure, I think that's the only spot that needs to change.

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud