Open nmdefries opened 3 months ago
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
I know why that test is failing, and its related to a semi-bug that i thought i had documented already (but i apparently didn't). We can work around it with a small change to the test -- i will show you tomorrow or monday.
The test failure stems from this issue i just created: https://github.com/cmu-delphi/delphi-epidata/issues/1427
You can fix this PR in the meantime by changing the way rows are created and inserted by the failing test... Right now, it creates the rows by a list comprehension and then inserts them all at once. I think that if you move the call to self._insert_rows()
inside of one or both of those for
loops, it should do the trick (🤞).
Changed that here. Based on the previous failure, I think that's the only spot that needs to change.
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
Closes https://github.com/cmu-delphi/delphi-epidata/issues/232
Summary:
Calculate and include
min_issue
in metadata.Prerequisites:
dev
branchdev