cmu-delphi / delphi-epidata

An open API for epidemiological data.
https://cmu-delphi.github.io/delphi-epidata/
MIT License
100 stars 62 forks source link

feat: port pyclient build config to pyproject.toml #1470

Closed dshemetov closed 4 weeks ago

dshemetov commented 1 month ago

Summary:

I hoped the more modern config's dynamic metadata would work, but it only works if __version__ is defined explicitly in __init__.py, not imported from delphi_epidata.py (importing delphi_epidata.py errors at build-time because the dependencies in that file aren't installed in the build environment (just setuptools)).

So, this doesn't come with a useful feature, it's just a lateral move to the more modern packaging config.

On the plus side, I learned a lot by reading parts of these guides:

Might be handy in the future when we do #939 and other such changes.

Prerequisites:

sonarcloud[bot] commented 4 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

dshemetov commented 4 weeks ago

Good point, thanks! I swapped the commands over to the new ones (sdist and wheel) and added the new build dependency to CI.

Also updated the publish action based on hints from my IDE:

image

And updated changelog too (I figure we can just keep the changelog dates approximate? Doesn't feel like a big deal if those are one day off).

melange396 commented 4 weeks ago

we can always fix the date on release day