Switch Google Health Trends and Google Symptoms inactive/active marking

cmu-delphi / delphi-epidata

An open API for epidemiological data.

https://cmu-delphi.github.io/delphi-epidata/

MIT License

102 stars 68 forks source link

Switch Google Health Trends and Google Symptoms inactive/active marking #1538

Closed nmdefries closed 2 months ago

nmdefries commented 3 months ago

Summary:

Mark Google Health Trends as inactive. Rename Google symptoms page. Make all headers have the same format (nav_order in the same place).

Prerequisites:

[x] Unless it is a documentation hotfix it should be merged against the dev branch
[x] Branch is up-to-date with the branch to be merged with, i.e. dev
[x] Build is successful
[x] Code is cleaned up and formatted

sonarcloud[bot] commented 3 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

nmdefries commented 3 months ago

The Covidcast data source pages are no longer ordered alphabetically. Nothing we changed here or in https://github.com/cmu-delphi/delphi-epidata/pull/1500 should have changed that (everything at the same nav order is sorted automatically) so the behavior should match that in production. Maybe this is a local issue? It's not intrusive, so will look into this later if it continues to be a problem.

nmdefries commented 3 months ago

Ah, apparently "The order of pages with equal nav_order parameters is unstable: it may change with each build" (theme docs).

nmdefries commented 2 months ago

I'll work on alphabetization in another PR, so this is ready to review, @tinatownes.