Open dshemetov opened 1 year ago
What all does geomapping include?
Included population data for msa, county, state
Convert geo abbreviations to/from names to/from codes
One/both of these two? Anything else?
Generally it feels like geomapping should be in its own package (delphi-utils port/wrapper, gtsibble, or something else), and incorporated here only when it's not going to pollute the namespace. However, there are a couple things that seem like they belong here:
Things that don't belong in epidatr unless we can incorporate them into objects for the above:
The complication is that how we provide 1. and 2. above would change depending on the interface of the geomapping package we would work with. E.g., do we need to define a custom subclass? Conversions to and from some standard class? Something else? And a really nice, general geomapping package would be a ton of work; I'm not sure if one exists.
inst/
? a separate package that we deprecate later? a delphi-utils wrapper?).Musings on use cases.
A few situations to think about:
Musings on long-term solution: this feels like it will be facilitated through some custom classes representing geo vectors, which we would use in this package and in epiprocess.
help
, methods
, etc. This would allow us to provide geomapping where we've made decisions and/or are out of date. There would be some constraints on the separate package implementation in order to be able to do this in a mostly-backward-compatible way.
One of the original PRD feature requests in #13 was to have a little bit of geomapping in this package. Should we? @lcbrooks @dsweber2