[x] Make sure this PR is against "dev", not "main" (unless this is a release
PR).
[x] Request a review from one of the current epidatr main reviewers:
brookslogan, dshemetov, nmdefries, dsweber2.
[x] Makes sure to bump the version number in DESCRIPTION. Always increment
the patch version number (the third number), unless you are making a
release PR from dev to main, in which case increment the minor version
number (the second number).
[x] Describe changes made in NEWS.md, making sure breaking changes
(backwards-incompatible changes to the documented interface) are noted.
Collect the changes under the next release number (e.g. if you are on
1.7.2, then write your changes under the 1.8 heading).
Change explanations for reviewer
missing doesn't count default values as non-missing. If a user doesn't pass geo_values or time_values (both of which default to "*" in pub_covidcast), or dates (in pub_covid_hosp_state_timeseries), the missing check fails. To avoid this, just don't check missingness of those two arguments.
Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch
Checklist
Please:
DESCRIPTION. Always increment the patch version number (the third number), unless you are making a release PR from dev to main, in which case increment the minor version number (the second number).Change explanations for reviewer
missingdoesn't count default values as non-missing. If a user doesn't passgeo_valuesortime_values(both of which default to "*" inpub_covidcast), ordates(inpub_covid_hosp_state_timeseries), themissingcheck fails. To avoid this, just don't check missingness of those two arguments.Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch