search

cmu-delphi / epipredict

Tools for building predictive models in epidemiology.
https://cmu-delphi.github.io/epipredict/
Other
8 stars 9 forks source link

simplify grab_residuals #271

Closed dajmcdon closed 9 months ago

dajmcdon commented 10 months ago

closes #270 .

dajmcdon commented 10 months ago

I kind of doubt that there is a test where a classifier calls this function. Are you thinking that there needs to be?

dshemetov commented 10 months ago

Can we bump minor/patch version and add a note to CHANGELOG?

dajmcdon commented 10 months ago

@dshemetov Sure, though I'm unfamiliar. What would you like to bump to? 0.0.7 or 0.0.6001? Something else?

dshemetov commented 10 months ago

0.0.7 sounds good to me.

dshemetov commented 10 months ago

This might do it for you (haven't tried).

dsweber2 commented 10 months ago

er, I was actually thinking was a model for which stats:residuals isn't defined (is it for quant_reg, for example?). Totally wrote the wrong thing sorry.

dajmcdon commented 10 months ago

residuals are just the difference between the training response and the point prediction in-sample (at least the kind we're using here), so would be mathematically defined for any regression engine (including quantile regression). This should fail if the engine is a classifier though.