cmu-delphi / epipredict

Tools for building predictive models in epidemiology.
https://cmu-delphi.github.io/epipredict/
Other
8 stars 9 forks source link

feat: check_enough_train_data #283

Closed dshemetov closed 8 months ago

dshemetov commented 8 months ago

Attempt at fixing #106.

It seems to work well (see the tests) for both geo pooled and non geo pooled (more generally key col pooled) cases, but I still don't know how to keep this from running at test time, where the number of data points available will be way different and may cause problems.

@dajmcdon any suggestions?

dajmcdon commented 8 months ago

@dshemetov One more thing before merging: can you add the check to the arx_classifier() and the smooth forecaster?

dshemetov commented 8 months ago

Sure, let me take a look at how much work that will be.