Closed dshemetov closed 3 months ago
Made the requested updates and force-pushed.
I'm getting the error locally
Error (test-target_date_bug.R:57:3): arx_classifier determines target_date where forecast_date exists
Error in `check_installs(object)`: This engine requires some package installs: 'xgboost'
which comes from the line
# test-target_date_bug.R, line 59
trainer = parsnip::boost_tree(mode = "classification", trees = 5),
I guess xgboost is present on your machine and on CI, but I'm missing it, not sure how. Should we add it to Suggests or change the example to minimize dependencies? @dajmcdon
I suspect it's just a problem local to your machine. {xgboost}
is in Suggests already, so it will be installed in CI.
Checklist
Please:
DESCRIPTION
andNEWS.md
. Always increment the patch version number (the third number), unless you are making a release PR from dev to main, in which case increment the minor version number (the second number).Change explanations for reviewer
Update the predictor default to the value of the outcome arg in
arx_forecaster
.Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch