cmu-delphi / epipredict

Tools for building predictive models in epidemiology.
https://cmu-delphi.github.io/epipredict/
Other
8 stars 8 forks source link

Djm/deprecate #331

Closed dajmcdon closed 1 month ago

dajmcdon commented 1 month ago

Checklist

Please:

Change explanations for reviewer

In reviewing #296 , some of the error message changes I was suggesting seemed to borrow from existing tidymodels functions. All of these are internal, and we don't actually need them.

@dsweber2 note also the internal versions of purrr functions. This avoids the need to import the package. These are "in" {rlang} and accessible as usethis::use_standalone("r-lib/rlang", "purrr"), for example.

dajmcdon commented 1 month ago

@dsweber2 OK. I refactored bake.epi_recipe() to fix the issue with the tests I'd removed. This now results (correctly) in an epi_df. But note that the column order is different. It is now the order enforced by epiprocess::as_epi_df.

Also added a test to check that my refactor works as expected.

epi_juice() was internal to bake.epi_recipe() and is no longer needed for anything.

dajmcdon commented 1 month ago

...man/add_model.Rd is getting renamed to man/Add_model.Rd when I run document

Mine as well. I think it's like that on dev.