search

cmu-delphi / epipredict

Tools for building predictive models in epidemiology.
https://cmu-delphi.github.io/epipredict/
Other
8 stars 8 forks source link

`default` value isn't used by `epi_lag` or `epi_ahead` #338

Open dsweber2 opened 3 weeks ago

dsweber2 commented 3 weeks ago

Fairly minor problem but neither actually passes the default value through add_shifted_columns to epi_shift_single

dsweber2 commented 3 weeks ago

see https://github.com/cmu-delphi/epipredict/blob/de6e1db8919aadd44b639da2a0f8860a6af1d358/R/step_epi_shift.R#L245-L250

soft block by https://github.com/cmu-delphi/epipredict/pull/296, since that refactors these into a single function, which would make this significantly more awkward

dajmcdon commented 2 weeks ago

The set of arguments is meant to match https://recipes.tidymodels.org/reference/step_lag.html. But there are no values to fill. It is safe to remove this.

dsweber2 commented 2 weeks ago

I was going to add support for it, since that's basically the same amount of work; would you rather it be gone?