Missing rlang imports - Githubissues

cmu-delphi / epipredict

Tools for building predictive models in epidemiology.

https://cmu-delphi.github.io/epipredict/

Other

8 stars 8 forks source link

Missing rlang imports #339

Closed dajmcdon closed 3 weeks ago

dajmcdon commented 3 weeks ago

Checklist

Please:

[x] Make sure this PR is against "dev", not "main".
[x] Request a review from one of the current epipredict main reviewers:

Change explanations for reviewer

see name of branch and commit messages

dsweber2 commented 3 weeks ago

weird that is_true and is_logical only come through as problems in a note whereas select was classed as an error. Good to have a fix anyway.

It looks like the only way to make the rest of those notes go away is something like this, where we replace e.g. time_value with .data$time_value, which is an unfortunate amount of bloat, if straightforward.

dsweber2 commented 3 weeks ago

The styler has some opinions on those vignette changes btw; mostly adding more newlines on top of the ones you added