Closed dshemetov closed 1 week ago
I'm working on a more complicated refactor of this, but the short version is I don't think this is the right behaviour. An epi_recipe should be a subclass of recipe (it isn't currently) and operate on non-epi_df.
In the meantime, if you want it to warn on epi_recipe.default()
that's fine, but it should produce a recipe.
A user who downloads our package shouldn't be prevented from recipe behaviour just because they started with the wrong function.
@dajmcdon Cool, I switched this change over to a warning instead.
Checklist
Please:
DESCRIPTION
andNEWS.md
. Always increment the patch version number (the third number), unless you are making a release PR from dev to main, in which case increment the minor version number (the second number).epiprocess
version in theDESCRIPTION
file ifepiprocess
soonepipredict
andepiprocess
Change explanations for reviewer
Only allows epi_df in epi_recipe and everything else just gives a clear error as such. Open to conversation about this, I don't know if falling back to regular recipes is useful sometimes, I haven't needed that functionality, but if it's not, then this is the behavior I prefer.
Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch