cmu-delphi / epipredict

Tools for building predictive models in epidemiology.
https://cmu-delphi.github.io/epipredict/
Other
10 stars 10 forks source link

`key_colnames()` is called with ignored argument `extra_keys =` #412

Closed brookslogan closed 1 week ago

brookslogan commented 1 month ago

though whenever extra_keys = is passed to key_colnames in the tests, it appears that it's of length 0 anyway. Perhaps passing this arg isn't needed anymore? Or maybe we are missing test cases where it does matter + actually respecting it in epiprocess.

(I'm adding a dots-empty checks upstream in epiprocess, which flagged this.)