search

cmu-delphi / exploration-tooling

tools for evaluating and exploring forecasters
Other
0 stars 0 forks source link

testing: ab testing branch for epiprocess r6 refactor #112

Closed dshemetov closed 4 months ago

dshemetov commented 5 months ago

Companion branch for https://github.com/cmu-delphi/epiprocess/pull/431.

Reduces the covid_hosp_explore project to a subset of the forecasters for faster comparison. I found no differences in the forecast outputs. See the r6_refactor.R script for instructions for how to replicate.

nmdefries commented 5 months ago

My run is failing here. Looks like the as_of function is supposed to come from epiprocess, so it should be @importFromed epiprocess above and docs rebuilt.

Edit: Hmm, getting ✖ looping.R:26: @importFrom Excluding unknown export from epiprocess: 'as_of'. when I try this locally.

dshemetov commented 5 months ago

Ah right, so that's a line changed in this PR's branch and it dispatches to as_of.epi_archive on the refactor branch. The current live exploration-tooling+epiprocess combo uses epi_archive$as_of (which is the old R6 method for doing as_of on archives). Iirc this was the only line I had to refactor in exploration-tooling to get the refactor branch to work.

dshemetov commented 4 months ago

Try these:

# A branch
pak::pkg_install("cmu-delphi/exploration-tooling@ds/epiprocess")
pak::pkg_install("cmu-delphi/epiprocess@ds/r6-clean")

# B branch
pak::pkg_install("cmu-delphi/exploration-tooling@main")
pak::pkg_install("cmu-delphi/epiprocess@dev")
nmdefries commented 4 months ago

Thanks, will try these branch combos.