Since JHU has been discontinued, forecasts using it as truth data (for plotting and for scoring) are no longer supported by ForecastHub. Forecasts for cases and deaths are moving to "archival" status and should be differentiated from the active target variable hospital admissions.
To do so, cases and deaths forecasts will be displayed in a separate tab on the dashboard. Since we want to have the new tab use the same/existing format as the "current" tab, the data handling and plotting logic will be shared.
IDs of objects in the dashboard (plots, text, buttons) must be unique, so to reuse the code in a general way, modify interactive object IDs by appending a tab-dependent suffix. Add reactivity to support this.
Note:
At the moment, this new tabbed dashboard fetches all the data on load. This will be improved in an upcoming PR.
The separate-dashboards version of this is working at commit fe4f6b7.
~Tests are fixed on another branch, will merge that in when available. The issue is with the GH action and not with the code here, so the dashboard behavior won't be modified.~ This is resolved.
Description
Since JHU has been discontinued, forecasts using it as truth data (for plotting and for scoring) are no longer supported by ForecastHub. Forecasts for cases and deaths are moving to "archival" status and should be differentiated from the active target variable hospital admissions.
To do so, cases and deaths forecasts will be displayed in a separate tab on the dashboard. Since we want to have the new tab use the same/existing format as the "current" tab, the data handling and plotting logic will be shared.
IDs of objects in the dashboard (plots, text, buttons) must be unique, so to reuse the code in a general way, modify interactive object IDs by appending a tab-dependent suffix. Add reactivity to support this.
Note:
Changes
data.R
-- simplify data loadserver.R
-- observe tab change; send results to tab-appropriate output idsui.R
-- factor out plot area layout and reuse for "archive" tabstyle.css
-- apply the same formatting to the "archive" tabFixes
Partially addresses https://github.com/cmu-delphi/forecast-eval/issues/175