search

cmu-delphi / forecast-eval

delphi.cmu.edu/forecast-eval
MIT License
5 stars 2 forks source link

minor: pain points running from scratch #288

Closed dsweber2 closed 1 year ago

dsweber2 commented 1 year ago

Things that got in the way of running this the first time.

fixes #287

nmdefries commented 1 year ago

Ha, I just opened a PR to fix these issues too...

nmdefries commented 1 year ago

What do you want to do with the two PRs? We could merge them into each other and then into dev. Mine is here.

I didn't know about the ?= assignment operator, good use of that here, since we assume imageTag is defined in the environment.

dsweber2 commented 1 year ago

I think just closing this one is less work? either way

nmdefries commented 1 year ago

Superseded by https://github.com/cmu-delphi/forecast-eval/pull/289