search

cmu-delphi / forecast-eval

delphi.cmu.edu/forecast-eval
MIT License
5 stars 2 forks source link

Cleanup after 7.1.0 release #292

Closed nmdefries closed 1 year ago

nmdefries commented 1 year ago

Keep version on dev up to date with main.

nmdefries commented 1 year ago

Release Main failure is known, occuring after merge of https://github.com/cmu-delphi/forecast-eval/pull/285. Seems to be related to the recent deprecation of Node12. I'll need to fix that on dev and do another merge into main.

dsweber2 commented 1 year ago

do we have a way to tell the robots to run the CI again, after the other pull request was merged?

nmdefries commented 1 year ago

So https://github.com/cmu-delphi/forecast-eval/pull/293 was added to dev. We need to merge dev into main before trying to release main again using the automatic method (since otherwise it won't have the updated workflow file and will fail in the same way).

I can run the Release Main workflow manually off of the dev branch, but it's not clear to me that that would be able to release main (which has it's own version of that workflow file) without error. I never considered doing this :thinking:

Edit: Looking at this idea in more detail, it wouldn't work with the current workflow file. We need to use the workflow file on dev but process the main branch in the workflow (to get up to date version values). However, the workflow via actions/checkout always processes the branch the workflow was run on. We could update the workflow to process a different branch than it is run on, but that's beyond the scope of this.