cmu-delphi / signal_documentation

3 stars 0 forks source link

Adds the signals sync script here #171

Closed korlaxxalrok closed 3 months ago

korlaxxalrok commented 3 months ago

This PR makes it so we can build this script into the app container image and ultimately call it from there via some remote mechanism.

Reasons:

Changes here:

There has been some discussion in a different repo on a few changes we might want to make. Gonna put a link to those here: https://github.com/cmu-delphi/delphi-admin/pull/205

korlaxxalrok commented 3 months ago

@dmytrotsko I've tested most of this in staging and it seems to work. The script doesn't seem to output anything, but I was able to observe the associated DB query. I've also tested running it from Cronicle.

Let me know if you think we should go another way, but this seems like it will work, and we are more likely to keep the script updated in this repo vs. delphi-admin.

(Sorry about adding the package sort to this PR! I only added sqlalchemy and mysql-connector-python.)

korlaxxalrok commented 3 months ago

@melange396 Tagging you here because you had some potential changes you wanted made in https://github.com/cmu-delphi/delphi-admin/pull/205.

melange396 commented 3 months ago

cool, ill copy my comments from the other PR into here