cmu-delphi / signal_documentation

3 stars 0 forks source link

Make unique signal "identifier" strings available #31

Open melange396 opened 1 year ago

melange396 commented 1 year ago

They're not always very "friendly" or "human-readable", but these pages should show the unique signal identifier strings; Those strings are how signals are accessed and referred to in the covidcast/epidata API.

For example, the page for the doctor-visits "COVID-Related Doctor Visits (Day-adjusted)" signal ( https://staging/signals/signals/471/ ) should show its API identifier: smoothed_adj_cli.

BrainIsDead commented 1 year ago

Actually, we have ID, and detailed views /signal-documentation/signals/<id>/ , but additionally I have added id column to the table

https://github.com/cmu-delphi/signal_documentation/assets/24429352/001f181c-73a7-42e5-a4cf-d232f342117c

melange396 commented 1 year ago

Cool, your screen capture clip shows the "Signal" column on the main view -- that wasn't showing up on the staging server instance before (there was a "Signal" column, but it always showed "None"). Your clip shows it is still missing from the detailed view page though.

I don't think you need the numeric id, the interface is already busy enough without it and it probably isn't going to be useful to users.

BrainIsDead commented 1 year ago

@melange396 oh, you are talking about <td>{{ signal.base }}</td> column actually I can show id there (or not only id), and place redirect on it by the click