cmu-delphi / www-covidcast

Front end for interactive visualizations powering the COVIDcast website.
https://delphi.cmu.edu/covidcast/
MIT License
13 stars 2 forks source link

Remove inactive sources from indicator status dashboard #1227

Closed rzats closed 11 months ago

rzats commented 1 year ago

Prerequisites:

Summary

Prevents the inactive/stale sensors from showing up in the indicator status dashboard. Before:

Screenshot 2023-09-22 at 18 11 38

After:

Screenshot 2023-09-22 at 18 11 04
netlify[bot] commented 1 year ago

Preview link ready!

Name Link
Latest commit 4f72f5c4dcd718d3f9c1229f57d858f4f4f93721
Latest deploy log https://app.netlify.com/sites/cmu-delphi-covidcast/deploys/651448cbd3106e0008218e47
Deploy Preview https://deploy-preview-1227--cmu-delphi-covidcast.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

rzats commented 1 year ago

@melange396 that information is already used here, where we filter out a bunch of sensors where the active property in the metadata is set to false. However, for the inactive sensors currently on the dashboard, that property is true.

A "smarter" solution could be to dynamically filter out all sensors that are N days out of date, which is similar to the thought process used to create the hardcoded list in the first place. I'd suggest a 180-day threshold in that case.

melange396 commented 11 months ago

We got rid of the inactive sources by updating the signal metadata in https://github.com/cmu-delphi/delphi-epidata/pull/1259#issuecomment-1758071698 and https://github.com/cmu-delphi/delphi-epidata/pull/1306#issuecomment-1758124724.

The change in this PR would hide signals marked active that havent been updated for ~half a year, which is good for keeping the dashboard clean but it might obscure signals that we need to take action on (like marking them inactive or by fixing them in some other way). I'm going to close this for now, but we can revisit it later if something similar comes up.