search

cmu-delphi / www-covidcast

Front end for interactive visualizations powering the COVIDcast website.
https://delphi.cmu.edu/covidcast/
MIT License
13 stars 2 forks source link

OKRS-24-55 #1243

Closed dmytrotsko closed 6 months ago

dmytrotsko commented 8 months ago

Prerequisites:

Summary

"latest known data" link now preserves context. Set default date to the date when we have data for all 3 sensors in 'Overview'. When date is present in URL, the date doesn't change to "default date". Added "NoRecentDataWarning" in order to nofity user about "old" data

netlify[bot] commented 8 months ago

Preview link ready!

Name Link
Latest commit a465b1adc12a37bed34ed89d561eb878605f97be
Latest deploy log https://app.netlify.com/sites/cmu-delphi-covidcast/deploys/6627d894b13ec90008b3e315
Deploy Preview https://deploy-preview-1243--cmu-delphi-covidcast.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

dmytrotsko commented 6 months ago

This looks great! I especially appreciate how you got rid of the asterisks and added tooltip hovers for the latest dates of each of the 3 highlighted indicators.

There is one behavior that we might want to change though (and we can merge this PR and fix it later, if necessary) -- when you go to the dashboard without any url parameters (like https://deploy-preview-1243--cmu-delphi-covidcast.netlify.app/ ), it shows the warning message as appropriate. However, when you go to the dashboard with a date specified that matches minMaxDate, it still shows the warning message (for instance, as of today 20240416, the most recent date with all 3 indicators available is 20240329, so today this happens when you visit https://deploy-preview-1243--cmu-delphi-covidcast.netlify.app/?date=20240329 ). This doesn't give incorrect information, but it could be fairly confusing for users.

Yeah, I agree that it is uncorrect behaviour and I wanted to fix that, but I have not found how to do that yet.

melange396 commented 6 months ago

ah crap, build is now failing because prettier doesnt like something in src/blocks/NoRecentDataWarning.svelte

melange396 commented 6 months ago

thanks Dmytro, youre the best!