search

cmu-delphi / www-epivis

An interactive tool for visualizing epidemiological time-series data.
http://delphi.cmu.edu/epivis/
MIT License
1 stars 3 forks source link

Upgrade EpiVis dashboard #36

Closed rzats closed 1 month ago

rzats commented 6 months ago

Summary of changes:

Fixes:

rzats commented 6 months ago

Notes from the meeting:

rzats commented 5 months ago

@melange396 updated this PR as well!

rzats commented 3 months ago

@dshemetov this is ready for a re-review! A couple of notes:

the 'h' hotkey doesn't bring up the help tour

Fixed!

When I click import datasets from API and I select FluView, the app hangs indefinitely, which didn't happen before. Something about the way the initial dataset is loaded might be off?

This would happen before if you were to try loading the same dataset twice. I added an extra check for that.

I'm not sure what "match defaults with COVIDcast dashboard" means; do we want FluView to be the default? if so, this is done, if not, then we should decide what to display

IMO this is done, but I can set the default to something else as well.

I see the EpiVis sample is still in the menu, though deactivated. We should probably remove this completely, seems unnecessary and distracting.

Done!

I would choose a different icon than a gear for the autofit functionality. Gear made me think it was a "general settings" button. Maybe something more like this or like this?

Done, went for the up-down icon.

rzats commented 3 months ago

@dshemetov

a subissue here is that I can't seem to select US National when using the COVID Hospitalization dataset; is this a bug or an api limitation or something else?

It is indeed an API limitation! That dataset works on the state level only. It seems to be a subset of the overall HHS dataset, which does offer more geo resolutions.

very strange behavior with automatic resizing when adding the COVID Hospitalizations as a dataset

This seems to be a CSS issue: if too many datasets are added to the left sidebar, it overflows offscreen. I've fixed this with the latest commit!

rzats commented 2 months ago

@melange396 applied all of your suggestions except a particular codestyle one!

include and exclude arguments in Chart.svelte:fitData()

These are removed in #41...

no automatic "fit" when a signal is specified in the base64-encoded URL

...and I doublechecked that this is now working as well.

melange396 commented 1 month ago

You should probably also bump the version number for this: https://github.com/cmu-delphi/www-epivis/blob/6e310a147578038a8bad94ff9525505afbff465b/package.json#L3

rzats commented 1 month ago

@melange396 applied the changes!