add CI and image generation

cmu-delphi / www-epivis

An interactive tool for visualizing epidemiological time-series data.

http://delphi.cmu.edu/epivis/

MIT License

1 stars 3 forks source link

add CI and image generation #4

Closed sgratzl closed 3 years ago

sgratzl commented 3 years ago

creates and compiles a standalone version using the new build tools
builds and image with the compiled files and pushes the image to ECR
trigger a pull/recreate of the image on the server using a webhook

dfarrow0 commented 3 years ago

tbh i'm a little lost. what's the end goal of this and related PRs? is there a discussion somewhere?

there are a series of dephi developer guides: backend -> frontend -> epidata, epicast, epivis. this PR removes the dockerfile and readme for epivis, but the dev guide is unchanged.
how does this change affect local development? can you still spin up a local docker container hosting the site for development?
the existing image builds on top of the common delphi_web image, which mirrors the prod setup (apache, eastern timezone, other settings), whereas the new image is based on nginx and doesn't seem to do any other configuration. why the switch?

tildechris commented 3 years ago

To follow-up on @dfarrow0's questions, we're investing in per-project docker infrastructure. See also: https://github.com/cmu-delphi/delphi-ansible-web

The goal is to automatically build images based on github events (i.e. merging to main), and deploy those images to web hosts. Projects will be available via reverse proxying, so delphi.cmu.edu/projectname will get pointed to the appropriate image. Local development should still be able to test using docker.

I think the main take-away from David's comments is that, yes, we should be updating the documentation. Let's aim to update all of that prior to making the production release of this new infrastructure.

@sgratzl, re: did you have a reason for starting with a new web image? I didn't know about the other existing image.

sgratzl commented 3 years ago

@sgratzl, re: did you have a reason for starting with a new web image? I didn't know about the other existing image.

back the common apache based setup didn't have any public docker image to base on. Moreover, since also in production each docker image will be isolated, they can use a simplified setup such as being hosted by an small NGINX, when it is just about hosting static files. One of the goals was to create isolated setups, which can be built locally and also by a simple CI without a complex support setup