Correctly compute whether an article has been archived

[mdlincoln]

Closes https://github.com/dSHARP-CMU/cmesh-dev/issues/331

This corrects a bug where articles archived through manual addition to issues were not being shown as archived on the article archive page.

Because of this change, we can remove the is_archived attribute as it's no longer called by the code and doesn't store information that can't be found by calling issues.exists()

[hachacha]

Sorry for coming in late to this after you did this work.

but i think 1 is this in the case of:

• create new article "earthworm town"
• create version of that article "earthworm town v2"
• add the newer version to some issue "JIMMY'S PICKS FOR HOME GARDENING"

because that article version is in some issue that's not necessarily an archive, does it still count as being archived? I think that's why there's a manual check. so removing is_archived from the model might not be the best solution unless i'm misunderstanding something in your PR.

2.

Right now, if you view an original article's "article archives" pages and it hasn't yet been archived, the archive warning in red doesn't appear.

I see the red text on the staging site... original: https://lps-staging.library.cmu.edu/ETHOS/plugins/archive_plugin/article/11/ new version: https://lps-staging.library.cmu.edu/ETHOS/plugins/archive_plugin/article/20/

The check in article_version_list : orig_article.issues.exists is weird though and should really be looking at orig_article.is_archived. right?

[mdlincoln]

closing in favor of the rearchitected issue-based archive model